[SYCL][WIP] Extend select_device to take parameters #2241
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows users to request a specific device of their choice, in terms of device_type, backend, and device_num. select_device now can take 3 OPTIONAL parameters for this purpose. When these 3 parameters are specified, the user can pin down a specific device on which they want to run a kernel. SYCL_DEVICE_TRIPLE will also affect this api, and filters out unspecified devices. If any device that can satisfy the paraemters, it will fall back to the default heuristic approach. (current implemantion) Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
s-kanaev
reviewed
Aug 3, 2020
| // Checks that only designated plugins are loaded when SYCL_DEVICE_TRIPLE is | ||
| // set. Checks that all different device types can be acquired from | ||
| // select_device() | ||
| // UNSUPPORTED: windows |
There was a problem hiding this comment.
Why?
Will there be a dedicated test for windows platform?
|
Why are we changing the SYCL APIs? We should not do this. |
|
The name |
bso-intel
changed the title
Signed-off-by: Byoungro So <[email protected]>
|
Please stop pursuing this path. |
|
@bso-intel, should we close this PR? |
Yes, I will have to open another PR for similar work later. |
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[L0 v2] implement native APIs and urMemBufferPartition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to request a specific device of their choice,
in terms of device_type, backend, and device_num.
select_device now can take 3 OPTIONAL parameters for this purpose, so keeping backward compatibility.
When these 3 parameters are specified, the user can pin down a specific device on which they want to run a kernel.
A new env var SYCL_DEVICE_TRIPLES will also affect this api, and filters out unspecified devices.
If any device that can satisfy the parameters is not found, it will fall back to the default heuristic approach. (current implementation)
Signed-off-by: Byoungro So [email protected]